Accueil » Contributions » Shnoulle (Denis Chenu) · GitHub

Shnoulle (Denis Chenu) · GitHub

[25 septembre 2020 - 15:49 | Shnoulle (Denis Chenu) · GitHub]

Shnoulle commented on pull request LimeSurvey/LimeSurvey#1603 Sep 25, 2020 Shnoulle commented Sep 25, 2020 It's not because a bad code is here for years we need to keep it … @olleharstedt any advice ?

[25 septembre 2020 - 15:48 | Shnoulle (Denis Chenu) · GitHub]

Shnoulle commented on pull request LimeSurvey/LimeSurvey#1603 Sep 25, 2020 Shnoulle commented Sep 25, 2020 Yes, and ?

[25 septembre 2020 - 15:45 | Shnoulle (Denis Chenu) · GitHub]

Shnoulle commented on pull request LimeSurvey/LimeSurvey#1603 Sep 25, 2020 Shnoulle commented Sep 25, 2020 If another LimeSurvey want to use jsonRPCClient : create a plugin and include your own jsonRPCClient. Can be an helper : see (...)

[25 septembre 2020 - 15:43 | Shnoulle (Denis Chenu) · GitHub]

Shnoulle commented on pull request LimeSurvey/LimeSurvey#1603 Sep 25, 2020 Shnoulle commented Sep 25, 2020 Then : it's not used by LimeSurvey core or test. Only if another tool include the file from LimeSurvey ? My opinion : we don't use it ? We don't (...)

[25 septembre 2020 - 15:24 | Shnoulle (Denis Chenu) · GitHub]

Shnoulle commented on pull request LimeSurvey/LimeSurvey#1603 Sep 25, 2020 Shnoulle commented Sep 25, 2020 Maybe it's best to remove the client since we don't uyse it in test too. We can add it in tests when we add a test. [shnoulle@poledra 3LTS]$ cd (...)